Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wget syntax in documentation #1609

Merged
merged 2 commits into from
Jan 31, 2020
Merged

Conversation

Lusitaniae
Copy link
Contributor

The syntax was wrong and doesn't work as expected

       -O file
       --output-document=file
           The documents will not be written to the appropriate files, but all will be concatenated together and written to file.  If - is used as file, documents
           will be printed to standard output, disabling link conversion.  (Use ./- to print to a file literally named -.)


Capital "O" solves it.

@claassistantio
Copy link

claassistantio commented Jan 30, 2020

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

codecov-io commented Jan 30, 2020

Codecov Report

Merging #1609 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1609      +/-   ##
==========================================
+ Coverage   60.69%   60.75%   +0.06%     
==========================================
  Files         107      107              
  Lines        8075     8075              
==========================================
+ Hits         4901     4906       +5     
+ Misses       2787     2784       -3     
+ Partials      387      385       -2
Impacted Files Coverage Δ
pkg/promtail/targets/filetarget.go 70.55% <0%> (+1.84%) ⬆️
pkg/promtail/targets/tailer.go 75.86% <0%> (+2.29%) ⬆️

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit 34b3a76 into grafana:master Jan 31, 2020
@Lusitaniae Lusitaniae deleted the patch-1 branch February 17, 2020 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants