Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PeriodConfig documentation fix dynamodb -> aws-dynamo #1619

Merged
merged 1 commit into from
Feb 3, 2020
Merged

PeriodConfig documentation fix dynamodb -> aws-dynamo #1619

merged 1 commit into from
Feb 3, 2020

Conversation

shaikatz
Copy link
Contributor

@shaikatz shaikatz commented Feb 2, 2020

What this PR does / why we need it:
Documentation fix.
Looking at cortex NewIndexClient code, dynamodb is not an option. it should be aws or aws-dynamo

@claassistantio
Copy link

claassistantio commented Feb 2, 2020

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

Codecov Report

Merging #1619 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1619      +/-   ##
==========================================
- Coverage   60.95%   60.91%   -0.04%     
==========================================
  Files         108      108              
  Lines        8144     8144              
==========================================
- Hits         4964     4961       -3     
- Misses       2790     2791       +1     
- Partials      390      392       +2
Impacted Files Coverage Δ
pkg/promtail/targets/filetarget.go 68.71% <0%> (-1.85%) ⬇️
pkg/promtail/targets/tailer.go 73.56% <0%> (ø) ⬆️

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit 39c2868 into grafana:master Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants