Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds stringer methods for all ast expr types #1630

Merged
merged 2 commits into from
Feb 4, 2020

Conversation

owen-d
Copy link
Member

@owen-d owen-d commented Feb 4, 2020

Continuing some AST refactoring, this ensures all expressions impl fmt.Stringer in order to be able to move between an in memory AST and its string representation.

pkg/logql/ast.go Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Feb 4, 2020

Codecov Report

Merging #1630 into master will increase coverage by 0.24%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1630      +/-   ##
==========================================
+ Coverage   61.62%   61.87%   +0.24%     
==========================================
  Files         109      109              
  Lines        8264     8304      +40     
==========================================
+ Hits         5093     5138      +45     
+ Misses       2776     2773       -3     
+ Partials      395      393       -2
Impacted Files Coverage Δ
pkg/logql/ast.go 87.2% <100%> (+3.87%) ⬆️
pkg/ingester/transfer.go 65% <0%> (-1.43%) ⬇️
pkg/promtail/targets/filetarget.go 70.55% <0%> (+1.84%) ⬆️
pkg/promtail/targets/tailer.go 78.16% <0%> (+4.59%) ⬆️

Co-Authored-By: Cyril Tovena <cyril.tovena@gmail.com>
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit 6930fb2 into grafana:master Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants