fluent-plugin-grafana-loki: Update fluentd base image to current images (edge) #1703
+9
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated base image from: v1.3.2-debian to v1.9.2-debian-1.0. Changed ruby from 2.3.0 to 2.6.0.
|
|
cyriltovena
approved these changes
Feb 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR updates the base image of fluentd from: v1.3.2-debian to v1.9.2-debian-1.0, and changes the ruby version from 2.3.0 to 2.6.0.
The recommendation from fluentd is to utilize current images (edge) instead of the old v1.4 images, whenever possible. The v1.4 images are kept for backwards compatibility only.
See: https://hub.docker.com/r/fluent/fluentd/
Besides following the recommendations of upstream, this also produces a more versatile docker image, with more core modules included, such as
out_http: https://docs.fluentd.org/output/http, which was the original motivation for this change.Which issue(s) this PR fixes:
No issue reported.
Special notes for your reviewer:
None
Checklist
N/A