Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add overrides file for our jsonnet library. #1705

Merged
merged 3 commits into from
Feb 24, 2020

Conversation

cyriltovena
Copy link
Contributor

This will now automatically load up overrides for tenants if any for each component.

Signed-off-by: Cyril Tovena cyril.tovena@gmail.com

This will now automatically load up overrides for tenants if any for each component.

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
@codecov-io
Copy link

codecov-io commented Feb 14, 2020

Codecov Report

Merging #1705 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1705      +/-   ##
==========================================
- Coverage   63.42%   63.38%   -0.04%     
==========================================
  Files         121      121              
  Lines        9003     9003              
==========================================
- Hits         5710     5707       -3     
- Misses       2875     2876       +1     
- Partials      418      420       +2
Impacted Files Coverage Δ
pkg/promtail/targets/tailer.go 73.56% <0%> (-2.3%) ⬇️
pkg/promtail/targets/filetarget.go 68.71% <0%> (-1.85%) ⬇️
pkg/logql/evaluator.go 91.81% <0%> (+0.58%) ⬆️

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Copy link
Member

@joe-elliott joe-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit bac3afe into grafana:master Feb 24, 2020
Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slim-bean
Copy link
Collaborator

you snooze you lose apparently ಠ_ಠ @joe-elliott

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants