Non-root user docker image for Loki. #1706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1706 +/- ##
==========================================
- Coverage 62.56% 62.54% -0.03%
==========================================
Files 112 112
Lines 8615 8615
==========================================
- Hits 5390 5388 -2
- Misses 2822 2823 +1
- Partials 403 404 +1
|
|
Is there a reason we wouldn't want to do this in promtail also? |
|
No I want to but the image is more complex (debian) and I wanted to start with Loki first, see how it goes for a while. |
|
Should we still merge this and tackle promtail later ? |
owen-d
approved these changes
Mar 17, 2020
cyriltovena
pushed a commit
to cyriltovena/loki
that referenced
this pull request
Jun 11, 2021
* Refactor enocding.Chunk.Add Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in> * Undo pointer-to-slice changes in varbit Signed-off-by: Bryan Boreham <bryan@weave.works> * Error on setting Delta encoding Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in> * Don't replace Delta with DoubleDelta Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For best pratices. Fixes #1244 since the other CVE seems to be clear out now.
However promtail has couple of high and critical CVE when scanning using trivy but none
of them seems actionable as debian doesn't seems to want to fix them or include upstream fixes.