Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fluent-bit: Fix panic error when AutoKubernetesLabels is true #1717

Merged
merged 1 commit into from
Feb 21, 2020

Conversation

adityacs
Copy link
Collaborator

@adityacs adityacs commented Feb 19, 2020

What this PR does / why we need it:
Fluent-bit: Fix panic error when AutoKubernetesLabels is true

Which issue(s) this PR fixes:
Fixes #1524

Checklist

  • Tests updated

cmd/fluent-bit/loki.go Outdated Show resolved Hide resolved
cmd/fluent-bit/loki.go Outdated Show resolved Hide resolved
cmd/fluent-bit/loki.go Outdated Show resolved Hide resolved
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, you just need to fix the lint error and we're good to go.

@adityacs
Copy link
Collaborator Author

@cyriltovena done

@cyriltovena cyriltovena merged commit a4d671b into grafana:master Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

encounter panic when turning on AutoKubernetesLabels
2 participants