Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose QueryType function. #1719

Merged
merged 2 commits into from
Feb 19, 2020
Merged

Conversation

cyriltovena
Copy link
Contributor

Signed-off-by: Cyril Tovena cyril.tovena@gmail.com

I want to reuse this somewhere, without leaking ast private nodes.

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
@codecov-io
Copy link

codecov-io commented Feb 19, 2020

Codecov Report

Merging #1719 into master will decrease coverage by 0.06%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1719      +/-   ##
==========================================
- Coverage   64.01%   63.95%   -0.07%     
==========================================
  Files         121      121              
  Lines        9027     9028       +1     
==========================================
- Hits         5779     5774       -5     
- Misses       2844     2847       +3     
- Partials      404      407       +3
Impacted Files Coverage Δ
pkg/logql/metrics.go 85.71% <66.66%> (-6.88%) ⬇️
pkg/promtail/targets/tailer.go 73.56% <0%> (-4.6%) ⬇️

Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit cdd08b0 into grafana:master Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants