Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix outdated link to fluentd #1728

Merged
merged 1 commit into from
Feb 24, 2020
Merged

Conversation

irake99
Copy link
Contributor

@irake99 irake99 commented Feb 22, 2020

What this PR does / why we need it:
The Link of fluentd in docs/README.md is outdated.

Which issue(s) this PR fixes:
No issue reported.

Special notes for your reviewer:
None.

Checklist

  • Documentation added
  • Tests updated

@claassistantio
Copy link

claassistantio commented Feb 22, 2020

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

Codecov Report

Merging #1728 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1728      +/-   ##
==========================================
+ Coverage   64.16%   64.21%   +0.05%     
==========================================
  Files         121      121              
  Lines        9024     9024              
==========================================
+ Hits         5790     5795       +5     
+ Misses       2829     2826       -3     
+ Partials      405      403       -2
Impacted Files Coverage Δ
pkg/logql/evaluator.go 91.22% <0%> (-0.59%) ⬇️
pkg/ingester/transfer.go 66.42% <0%> (+1.42%) ⬆️
pkg/promtail/targets/filetarget.go 70.55% <0%> (+1.84%) ⬆️
pkg/promtail/targets/tailer.go 75.86% <0%> (+2.29%) ⬆️

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit 8b8d3a4 into grafana:master Feb 24, 2020
@irake99 irake99 changed the title docs: fix outdated link of fluentd docs: fix outdated link to fluentd Feb 24, 2020
cyriltovena pushed a commit to cyriltovena/loki that referenced this pull request Jun 11, 2021
…l components (grafana#1728)

Signed-off-by: Roger Steneteg <rsteneteg@ea.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants