Fix nil pointer dereference in ingester client #1730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1730 +/- ##
==========================================
+ Coverage 64.16% 64.23% +0.07%
==========================================
Files 121 121
Lines 9024 9024
==========================================
+ Hits 5790 5797 +7
+ Misses 2829 2825 -4
+ Partials 405 402 -3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fix nil pointer dereference in ingester client.
HealthClientwas missing in ingester client setup which caused nil pointer dereference here inclienthttps://github.com/cortexproject/cortex/blob/master/pkg/ingester/client/pool.go#L208Which issue(s) this PR fixes:
Fixes #1679