Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This logs queries with latency tag when recording stats. #1733

Merged
merged 2 commits into from
Feb 24, 2020

Conversation

cyriltovena
Copy link
Contributor

Useful for building a dashboard of slow queries.

I plan in the long term to add a dashboard using this in our mixin.

Signed-off-by: Cyril Tovena cyril.tovena@gmail.com

Useful for building a dashboard of slow queries.

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
@codecov-io
Copy link

Codecov Report

Merging #1733 into master will increase coverage by 0.11%.
The diff coverage is 93.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1733      +/-   ##
==========================================
+ Coverage   64.11%   64.22%   +0.11%     
==========================================
  Files         121      121              
  Lines        9069     9083      +14     
==========================================
+ Hits         5815     5834      +19     
+ Misses       2851     2846       -5     
  Partials      403      403
Impacted Files Coverage Δ
pkg/querier/queryrange/codec.go 94.28% <100%> (+1.63%) ⬆️
pkg/logql/evaluator.go 91.81% <100%> (ø) ⬆️
pkg/logql/metrics.go 91.11% <100%> (+10.46%) ⬆️
pkg/logql/engine.go 90.06% <100%> (ø) ⬆️
pkg/querier/queryrange/stats.go 82.75% <77.77%> (ø) ⬆️
pkg/promtail/targets/tailer.go 75.86% <0%> (-2.3%) ⬇️
pkg/ingester/transfer.go 65% <0%> (-1.43%) ⬇️
pkg/promtail/targets/filetarget.go 70.55% <0%> (+1.84%) ⬆️

@cyriltovena cyriltovena merged commit 9be21a7 into grafana:master Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants