Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor querier http error handling. #1745

Merged
merged 1 commit into from
Feb 26, 2020

Conversation

cyriltovena
Copy link
Contributor

Signed-off-by: Cyril Tovena cyril.tovena@gmail.com

This ensure we return proper status code depending on the error in the querier.

I'll send another PR to also update the frontend from cortex which has a similar change.

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

Codecov Report

Merging #1745 into master will increase coverage by 0.17%.
The diff coverage is 41.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1745      +/-   ##
==========================================
+ Coverage    64.2%   64.38%   +0.17%     
==========================================
  Files         121      121              
  Lines        9085     9080       -5     
==========================================
+ Hits         5833     5846      +13     
+ Misses       2848     2832      -16     
+ Partials      404      402       -2
Impacted Files Coverage Δ
pkg/querier/http.go 11.17% <41.17%> (+4.43%) ⬆️
pkg/ingester/transfer.go 65% <0%> (-1.43%) ⬇️
pkg/promtail/targets/filetarget.go 70.55% <0%> (+1.84%) ⬆️
pkg/promtail/targets/tailer.go 78.16% <0%> (+4.59%) ⬆️

@cyriltovena cyriltovena merged commit 6328146 into grafana:master Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants