Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

promtail: remove the read lines counter when the log file stops being tailed #1775

Merged
merged 1 commit into from
Mar 4, 2020
Merged

promtail: remove the read lines counter when the log file stops being tailed #1775

merged 1 commit into from
Mar 4, 2020

Conversation

slim-bean
Copy link
Collaborator

We do this with all the other per file metrics but missed this one which causes some metrics to "leak" over time as files come and go

Signed-off-by: Edward Welch edward.welch@grafana.com

@slim-bean
remove the read lines counter when the log file stops being tailed
68603c9 
Signed-off-by: Edward Welch <edward.welch@grafana.com>
@slim-bean slim-bean requested a review from rfratto March 4, 2020 22:05
rfratto
rfratto approved these changes Mar 4, 2020
View reviewed changes
Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@slim-bean slim-bean merged commit 8726033 into master Mar 4, 2020
@slim-bean slim-bean deleted the debug-expiration branch March 4, 2020 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfratto rfratto rfratto approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@slim-bean @rfratto