Error handling: Show data stream at "debug" level, not "warn" #1811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JamesJJ <jj@fcg.fyi>
|
|
Codecov Report
@@ Coverage Diff @@
## master #1811 +/- ##
==========================================
- Coverage 64.95% 64.86% -0.09%
==========================================
Files 122 122
Lines 9197 9197
==========================================
- Hits 5974 5966 -8
- Misses 2807 2820 +13
+ Partials 416 411 -5
|
|
This seems reasonable to me. @cyriltovena Thoughts? I don't have much overlap with this code. |
owen-d
approved these changes
Mar 17, 2020
cyriltovena
approved these changes
Mar 17, 2020
Signed-off-by: JamesJJ <jj@fcg.fyi>
|
Thanks @JamesJJ I'll take it from here ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Humbly request to change the log level of the stream dump:
I feel that most people may want to see
log.warn "failed to #{req.method} #{@uri} (#{res_summary})"however may not always need to seeYajl.dump(body). So propose to move the later down to "debug" level.This is especially relevant if fluent's input stream includes our own STDOUT/STDERR's output as is common when running in containers.
Many thanks for your time & consideration