Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log error message when source does not exist in extracted values #1815

Merged
merged 1 commit into from
Mar 23, 2020

Conversation

adityacs
Copy link
Collaborator

What this PR does / why we need it:
Log error message when source does not exist in extracted values

@codecov-io
Copy link

Codecov Report

Merging #1815 into master will increase coverage by 0.10%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1815      +/-   ##
==========================================
+ Coverage   64.75%   64.86%   +0.10%     
==========================================
  Files         122      122              
  Lines        9228     9230       +2     
==========================================
+ Hits         5976     5987      +11     
+ Misses       2836     2831       -5     
+ Partials      416      412       -4     
Impacted Files Coverage Δ
pkg/logentry/stages/metrics.go 59.67% <0.00%> (-0.65%) ⬇️
pkg/logql/evaluator.go 91.81% <0.00%> (+0.58%) ⬆️
pkg/promtail/targets/filetarget.go 70.55% <0.00%> (+1.84%) ⬆️
pkg/promtail/targets/tailer.go 78.40% <0.00%> (+6.81%) ⬆️

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit 7f61f11 into grafana:master Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants