Helm chart: Prevent prometheus to scrape both services #1817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bruno Clermont <bruno@robotinfra.com>
|
|
jeanlucmongrain
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1817 +/- ##
==========================================
+ Coverage 64.75% 64.83% +0.07%
==========================================
Files 122 122
Lines 9228 9228
==========================================
+ Hits 5976 5983 +7
+ Misses 2836 2831 -5
+ Partials 416 414 -2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loki metrics port is exposed through 2 different services.
ServiceMonitorlabel selector match both services. Prometheus scrape both services. But this is useless... as it's the same metrics.This PR add an extra label to the headless and switch the SM to force prometheus to scrap the headless service only