Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move default port for Loki to 3100 everywhere. #1838

Merged
merged 1 commit into from
Mar 23, 2020
Merged

Move default port for Loki to 3100 everywhere. #1838

merged 1 commit into from
Mar 23, 2020

Conversation

cyriltovena
Copy link
Contributor

@cyriltovena cyriltovena commented Mar 23, 2020 •
edited

Also fixes default value for the table manager that doesn't support 0 anymore on master.

Signed-off-by: Cyril Tovena cyril.tovena@gmail.com

I've tested helm to ensure we can also write to disk with the new rootless image. And everything looks good.

❯ k exec -it loki-stack-0 -- /bin/sh
/ $ ls /data/loki
chunks  index
/ $ ls /data/loki/chunks
ZmFrZS80YzQ3OWEyNTMzMDhjZDlhOjE3MTA3Yjc1ZDAyOjE3MTA3Yjc1ZGQ5OmQ1ZTJjM2Jm
ZmFrZS80ZmM4ODEwNWFiODE1YmVmOjE3MTA3Yjc1NjVmOjE3MTA3Yjc1NzAxOmQ2M2Q4NWQ5
ZmFrZS81ZTAwMTM2OTkxNzVmN2E4OjE3MTA3YjdkODRmOjE3MTA3YjdkODUwOjk1NjBiMjY2
ZmFrZS81ZTAwMTM2OTkxNzVmN2E4OjE3MTA3YmRkYTE5OjE3MTA3YmRkYTFhOjk0MDUyNTJm
ZmFrZS9hYTRhMzMwZWNiN2FkMzNkOjE3MTA3YmU0MGNiOjE3MTA3YmY0ODkzOjVhMTlkYmNm
ZmFrZS9mN2IzZDI2YzJkY2NiNGQ5OjE3MTA3YjdlYzMzOjE3MTA3YzNhNjk1OjU0YmRjMg==
ZmFrZS9mN2IzZDI2YzJkY2NiNGQ5OjE3MTA3YzZjODdlOjE3MTA3YzZjODgxOjg4NGRlNTlm

Fixes #1832

@cyriltovena
Move default port for Loki to 3100 everywhere.
d2777a3 
Also fixes default value for the table manager that doesn't support 0 anymore on master.

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
@cyriltovena cyriltovena mentioned this pull request Mar 23, 2020
Closed
rfratto
rfratto approved these changes Mar 23, 2020
View reviewed changes
Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cyriltovena cyriltovena merged commit fa51393 into grafana:master Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfratto rfratto rfratto approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Port change to 8080 broke docker-compose example
2 participants
@cyriltovena @rfratto