throw exceptions on HTTPTooManyRequests and HTTPServerError so FluentD will retry #1845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why circleCI is failing on a helm chart test, seems unrelated? |
Yeah not your fault, I fixed that on your branch. |
cyriltovena
reviewed
Mar 26, 2020
| Enabled: true | ||
| Style/HashTransformValues: | ||
| Enabled: true | ||
|
|
There was a problem hiding this comment.
Can you add a newline at the end please ?
cyriltovena
reviewed
Mar 26, 2020
fluentd/fluent-plugin-grafana-loki/spec/gems/fluent/plugin/loki_output_spec.rb
Outdated
Show resolved
Hide resolved
cyriltovena
reviewed
Mar 26, 2020
cyriltovena
approved these changes
Mar 26, 2020
…i_output_spec.rb spelling fix Co-Authored-By: Cyril Tovena <cyril.tovena@gmail.com>
…/loki into explicit_exceptions_for_retry
|
Forgot about bumping the gem version can you send a PR and I’ll deploy it. |
slim-bean
pushed a commit
that referenced
this pull request
Apr 1, 2020
…D will retry (#1845) * throw exceptions on HTTPTooManyRequests and HTTPServerError to trigger retry * fixed variable naming * Update fluentd/fluent-plugin-grafana-loki/spec/gems/fluent/plugin/loki_output_spec.rb spelling fix Co-Authored-By: Cyril Tovena <cyril.tovena@gmail.com> * removed newline Co-authored-by: Cyril Tovena <cyril.tovena@gmail.com> (cherry picked from commit 7413f11) Signed-off-by: Edward Welch <edward.welch@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Align retry behaviour with promtail. Trigger an explicit exception for HTTPTooManyRequests (429) and HTTPServerError (5xx) in the Output#write, so fluentD can retry as specified here https://docs.fluentd.org/output#control-retrying.
Checklist