Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: clean up schema recommendations #1852

Merged
merged 1 commit into from
Mar 26, 2020
Merged

docs: clean up schema recommendations #1852

merged 1 commit into from
Mar 26, 2020

Conversation

slim-bean
Copy link
Collaborator

Signed-off-by: Edward Welch edward.welch@grafana.com

@slim-bean
remove a few places we recommend the schema version and consolidate i…
798633f 
…n the configuration doc

Signed-off-by: Edward Welch <edward.welch@grafana.com>
@slim-bean slim-bean requested a review from rfratto March 26, 2020 14:00
rfratto
rfratto approved these changes Mar 26, 2020
View reviewed changes
Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good first step but there's a lot more we should do later to explain the schema better to users. I'd like to keep #1851 to keep track of that.

@rfratto rfratto mentioned this pull request Mar 26, 2020
Closed
@slim-bean slim-bean merged commit 00ee652 into master Mar 26, 2020
@slim-bean slim-bean deleted the clean-up-schema-recommendations branch March 26, 2020 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfratto rfratto rfratto approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@slim-bean @rfratto