Update Cortex to latest master #1869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Codecov Report
@@ Coverage Diff @@
## master #1869 +/- ##
=======================================
Coverage 64.64% 64.64%
=======================================
Files 125 125
Lines 9462 9462
=======================================
Hits 6117 6117
Misses 2921 2921
Partials 424 424
|
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
|
I think this is ready for review (@owen-d @cyriltovena). When deploying to kubernetes via Tanka, make sure to vendor updated json files first. |
|
I could use some help with Helm chart tests failing... New promtail configuration uses |
owen-d
reviewed
Apr 13, 2020
| @@ -152,7 +152,13 @@ func (m *mockChunkStore) GetChunkRefs(ctx context.Context, userID string, from, | |||
| } | |||
| refs = append(refs, r) | |||
| } | |||
| f, err := chunk.NewChunkFetcher(cache.Config{}, false, m.client) | |||
|
|
|||
| cache, err := cache.New(cache.Config{Prefix: "chunks"}) | |||
There was a problem hiding this comment.
the prefix was previously set in chunk.NewChunkFetcher. I like the explicit nature of this more 👍
| @@ -6,6 +6,16 @@ Unfortunately Loki is software and software is hard and sometimes things are not | |||
|
|
|||
| On this page we will document any upgrade issues/gotchas/considerations we are aware of. | |||
|
|
|||
| ## 1.5.0 | |||
There was a problem hiding this comment.
I'm torn - Cortex included many breaking changes in it's major (1.0) release. Should we increment to 2.0 here?
owen-d
approved these changes
Apr 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: This PR once again updates Cortex in Loki to latest master (just before cutting 1.0 version). Changelog since last Cortex update (just after 0.7 release) is massive and may require documentation changes (not yet done in this PR).
Cortex 1.0 changelog: https://cortexmetrics.io/docs/changelog/#1-0-0-2020-04-02
Checklist