Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: cleaning up the comments for the cache_config, default_validity option #1888

Merged
merged 3 commits into from
Apr 2, 2020

Conversation

slim-bean
Copy link
Collaborator

@slim-bean slim-bean commented Apr 2, 2020

Missed this on the last PR :(

Signed-off-by: Edward Welch edward.welch@grafana.com

Signed-off-by: Edward Welch <edward.welch@grafana.com>
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
How many commit do you need ? mouhahah

rfratto
rfratto previously requested changes Apr 2, 2020
Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make the README link to Upgrading Loki a full sentence rather than just the link?

@rfratto rfratto dismissed their stale review April 2, 2020 13:56

disagree and commit

Signed-off-by: Edward Welch <edward.welch@grafana.com>
Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but the links still point to 1.3.0 btw

Signed-off-by: Edward Welch <edward.welch@grafana.com>
@slim-bean slim-bean merged commit 4942593 into master Apr 2, 2020
@slim-bean slim-bean deleted the tweak-docs-again branch April 2, 2020 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants