Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes file size check for pipe, not provided by linux. #1893

Merged
merged 2 commits into from
Apr 3, 2020

Conversation

cyriltovena
Copy link
Contributor

Signed-off-by: Cyril Tovena cyril.tovena@gmail.com

Fixes #1892

Tested on linux and macos.

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
@codecov-io
Copy link

Codecov Report

Merging #1893 into master will increase coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1893   +/-   ##
=======================================
  Coverage   64.67%   64.67%           
=======================================
  Files         125      125           
  Lines        9477     9475    -2     
=======================================
- Hits         6129     6128    -1     
  Misses       2924     2924           
+ Partials      424      423    -1     
Impacted Files Coverage Δ
pkg/promtail/targets/manager.go 0.00% <0.00%> (ø)
pkg/promtail/targets/stdin_target_manager.go 71.21% <100.00%> (-1.26%) ⬇️
pkg/ingester/transfer.go 66.42% <0.00%> (+1.42%) ⬆️

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Copy link
Member

@owen-d owen-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

@owen-d owen-d merged commit 7573078 into grafana:master Apr 3, 2020
slim-bean pushed a commit that referenced this pull request Apr 6, 2020
* Removes file size check for pipe, not provided by linux.

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>

* Disable color on windows.

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
(cherry picked from commit 7573078)
cyriltovena pushed a commit to cyriltovena/loki that referenced this pull request Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pipe to promtail doesn't work on linux
3 participants