Fixes possible panic in json pipeline stage. #1894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was reported to me today and it happens because the previous source can be nil. This was only happening when debug log was on. And the problem was only in the json because it was using .String on a nil value. I've added a test and activate debug during tests to cover those path too. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1894 +/- ##
==========================================
- Coverage 64.67% 64.61% -0.06%
==========================================
Files 125 125
Lines 9477 9477
==========================================
- Hits 6129 6124 -5
- Misses 2924 2926 +2
- Partials 424 427 +3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was reported to me today and it happens because the previous source can be nil.
This was only happening when debug log was on. And the problem was only in the json because it was using .String on a nil value.
I've added a test and activate debug during tests to cover those path too.
Signed-off-by: Cyril Tovena cyril.tovena@gmail.com