Log docker driver config map. #1903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyriltovena
force-pushed
the
driver-log-config
branch
from
57aa7eb
to
fd01e59
Compare
This will allow users to verify which config option are passed to the driver. See dicussions here grafana#1868, it seems that it can be confusing when using docker-compose. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
cyriltovena
force-pushed
the
driver-log-config
branch
from
fd01e59
to
f91e989
Compare
owen-d
approved these changes
Apr 13, 2020
|
@cyriltovena feel free to fix the conflict & merge. |
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow users to verify which config option are passed to the driver.
See discussion here #1868, it seems that it can be confusing when using docker-compose.
Signed-off-by: Cyril Tovena cyril.tovena@gmail.com