docs: version pin the docker image in docker-compose #1945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the [documentation](https://github.com/grafana/loki/blob/master/docs/installation/docker.md) does version pin the links to specific versions of the docker-compose file, the file it docker-compose file does use the `latest` tag for loki. For an example of issues this causes see #1941
|
|
owen-d
approved these changes
Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
While the documentation does version pin the links to specific versions of the docker-compose file, the file it docker-compose file does use the
latesttag for loki.For an example of issues this causes see #1941
Which issue(s) this PR fixes:
Fixes #1941
Special notes for your reviewer:
Checklist