chunk lifespan histogram #1958
Merged
chunk lifespan histogram #1958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyriltovena
reviewed
Apr 17, 2020
| Name: "ingester_chunk_bounds_minutes", | ||
| Help: "Distribution of chunk end-start durations.", | ||
| // 15m to 2h | ||
| Buckets: prometheus.LinearBuckets(15, 15, 8), |
There was a problem hiding this comment.
I wonder if 2h is enough ?
There was a problem hiding this comment.
I guess if not we will change it let's try.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds a histogram reporting the average chunk lifespan (end-start) minutes.
Why
This allows us to track the bounds of flushed chunks. Currently we only track how long the reside in ingester memory. Understanding lifespans will help us parallelize more efficiently by reducing the likelihood of multiple queriers downloading the same chunks (with small interval configs). This should work very well with sharding, too.
Issue
closes #1902