Update cortex vendoring to latest master #1975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyriltovena
reviewed
Apr 23, 2020
| @@ -168,6 +169,13 @@ func (shard *indexShard) lookup(matchers []*labels.Matcher) []model.Fingerprint | |||
| if matcher.Type == labels.MatchEqual { | |||
| fps := values.fps[matcher.Value] | |||
| toIntersect = append(toIntersect, fps.fps...) // deliberate copy | |||
| } else if matcher.Type == labels.MatchRegexp && len(chunk.FindSetMatches(matcher.Value)) > 0 { | |||
There was a problem hiding this comment.
Nice I needed this, and I was bringing it in another PR.
|
@sandeepsukhani It might be easier for you to fix this than me? Looks like the |
sandeepsukhani
approved these changes
Apr 23, 2020
|
Thanks @sandeepsukhani ! |
…d7c74136cab1566fbd9583` Signed-off-by: Ed Welch <edward.welch@grafana.com>
Signed-off-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com>
…ore changes... Signed-off-by: Ed Welch <edward.welch@grafana.com>
slim-bean
force-pushed
the
revendor-cortex
branch
from
97134a4
to
3df3274
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit hash:
36496a074bc4530fb1d7c74136cab1566fbd9583Signed-off-by: Ed Welch edward.welch@grafana.com