Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added extraCommandlineArgs in values file #1981

Merged
merged 5 commits into from
Apr 24, 2020

Conversation

sshah90
Copy link
Contributor

@sshah90 sshah90 commented Apr 24, 2020

What this PR does / why we need it:
extraCommandlineArgs is missing from promtail values file so adding it with documentation and example to use it.

@cyriltovena
Copy link
Contributor

Hey @sshah90

Thanks a lot ! Can you bump the promtail chart and the loki-start chart version. Then we should be good to go !

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit b652f0a into grafana:master Apr 24, 2020
@sshah90
Copy link
Contributor Author

sshah90 commented Apr 24, 2020

@cyriltovena Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants