Spelling #2014
Spelling #2014
Conversation
|
|
| @@ -24,7 +24,7 @@ The current team members are: | |||
| - David Kaltschmidt [davkal](https://github.com/davkal) | |||
| - Edward Welch [slim-bean](https://github.com/slim-bean) | |||
| - Goutham Veeramachaneni [gouthamve](https://github.com/gouthamve) | |||
| - Joe Elliott [joe-elliot](https://github.com/joe-elliot) | |||
| - Joe Elliott [joe-elliott](https://github.com/joe-elliott) | |||
There was a problem hiding this comment.
Sorry @joe-elliott I did this.
| @@ -739,7 +739,7 @@ A **huge** thanks to the **36 contributors** who submitted **148 PR's** since 0. | |||
| * **Build** [1121](https://github.com/grafana/loki/pull/1121) **pracucci**: Publish loki-canary binaries on release | |||
| * **Build** [1054](https://github.com/grafana/loki/pull/1054) **pstibrany**: Fix dep check warnings by running dep ensure | |||
| * **Build/release** [1018](https://github.com/grafana/loki/pull/1018) **slim-bean**: updating the image version for loki-canary and adding the version increment to the release_prepare script | |||
| * **Build/CI** [997](https://github.com/grafana/loki/pull/997) **slim-bean**: full cirlce | |||
| * **Build/CI** [997](https://github.com/grafana/loki/pull/997) **slim-bean**: full circle | |||
There was a problem hiding this comment.
lol this misspelling was intentional FWIW 😉
There was a problem hiding this comment.
I'm pretty sure I looked at the PR and decided it didn't need to be misspelled.
If something is very clearly intentionally misspelled and doesn't make sense otherwise, I do leave it alone, e.g. a changelog entry of spelling: cirlce -> circle.
My personal preference is to not include misspellings in changelogs, unless it's announcing an API change.
| @@ -388,7 +388,7 @@ kvstore: | |||
| - <string> | |||
|
|
|||
| # The Dial timeout for the ETCD connection. | |||
| [dial_tmeout: <duration> | default = 10s] | |||
| [dial_timeout: <duration> | default = 10s] | |||
There was a problem hiding this comment.
are we 100% sure this is a typo in the docs and not a config actually spelled wrong?
There was a problem hiding this comment.
Afaict, the only instances of that are the document itself:
https://www.google.com/search?q=%22dial_tmeout%22
What this PR does / why we need it:
This fixes misspellings across the project.
MIsspellings make it hard for people to understand code / search for code, etc.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Misspellings identified by the check-spelling action.
It reported: jsoref@1c3399c#commitcomment-38840752
And it validated that the changes in this PR made it happy: jsoref@ab2955b
Checklist