Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: update Loki Helm Chart document to support Helm 3 #2038

Merged
merged 2 commits into from
May 8, 2020
Merged

Docs: update Loki Helm Chart document to support Helm 3 #2038

merged 2 commits into from
May 8, 2020

Conversation

oke-py
Copy link
Contributor

@oke-py oke-py commented May 5, 2020

What this PR does / why we need it:

This PR updates Loki Helm Chart document to support Helm 3.
-n flag has been deprecated for helm install.

Which issue(s) this PR fixes:
Fixes #1690

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

@cyriltovena
Copy link
Contributor

cyriltovena commented May 5, 2020

Hello and thank you !

Does that still work with 2.0 helm ? I don't think it does so many we should add instruction for helm 3 instead or replacing with 2.0 what do you think ?

@oke-py
Copy link
Contributor Author

oke-py commented May 6, 2020

The command that I updated does not work with Helm 2.

$ helm2 install loki-grafana stable/grafana -n loki 
Error: This command needs 1 argument: chart name

To install the chart in a specified namespace, the command is as below.

$ helm2 install stable/grafana -n loki-grafana --namespace loki

Given that Helm 3.0 was released about a half year ago, I think it'll be enough to support Helm 3.
However, it might be sure many developers are still using Helm 2.
How about showing both commands?

# with Helm 2
$ helm install stable/grafana -n loki-grafana --namespace <YOUR-NAMESPACE>

# with Helm 3
$ helm install loki-grafana stable/grafana -n <YOUR-NAMESPACE>

@cyriltovena
Copy link
Contributor

Yes let’s do that !

@oke-py
Copy link
Contributor Author

oke-py commented May 7, 2020

updated!

@codecov-io
Copy link

Codecov Report

Merging #2038 into master will decrease coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2038      +/-   ##
==========================================
- Coverage   64.05%   63.88%   -0.17%     
==========================================
  Files         133      133              
  Lines       10217    10217              
==========================================
- Hits         6544     6527      -17     
- Misses       3185     3203      +18     
+ Partials      488      487       -1     
Impacted Files Coverage Δ
pkg/promtail/positions/positions.go 47.32% <0.00%> (-13.40%) ⬇️
pkg/promtail/targets/tailer.go 76.13% <0.00%> (-2.28%) ⬇️

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for taking care of the feedback ! LGTM

@cyriltovena cyriltovena merged commit 918ba41 into grafana:master May 8, 2020
@oke-py oke-py deleted the helm3 branch May 9, 2020 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loki Helm Chart document should support Helm 3 ?
3 participants