Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extraOutputs variable to support multiple outputs for fluent-bit #2040

Merged
merged 2 commits into from
May 5, 2020

Conversation

avii-ridge
Copy link
Contributor

@avii-ridge avii-ridge commented May 5, 2020

What this PR does / why we need it:
Adds extra outputs feature for fluent-bit helm chart

Which issue(s) this PR fixes:
Fixes #2039

Special notes for your reviewer:

Checklist

  • Documentation added

@CLAassistant
Copy link

CLAassistant commented May 5, 2020

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

Codecov Report

Merging #2040 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2040      +/-   ##
==========================================
- Coverage   63.90%   63.88%   -0.02%     
==========================================
  Files         133      133              
  Lines       10217    10217              
==========================================
- Hits         6529     6527       -2     
- Misses       3202     3203       +1     
- Partials      486      487       +1     
Impacted Files Coverage Δ
pkg/logql/evaluator.go 90.69% <0.00%> (-0.59%) ⬇️

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit 69c1d1c into grafana:master May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow multiple outputs from fluent-bit
4 participants