Set JournalTarget Priority value to keyword #2087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good I think we should just add another internal label that can be relabeled and keep the current one instead of rewriting it, could be __journal__priority_string. Someone may prefer the number ! That would require a quick doc update for this new internal label. Should be simple WDYT? |
|
Yeah, makes sense to me. Will make the change |
adityacs
force-pushed
the
2084_set_journaltarget_symbolic_priority
branch
2 times, most recently
from
476f73f
to
e2f03a2
Compare
Codecov Report
@@ Coverage Diff @@
## master #2087 +/- ##
==========================================
- Coverage 61.24% 61.20% -0.04%
==========================================
Files 146 146
Lines 11187 11208 +21
==========================================
+ Hits 6851 6860 +9
- Misses 3788 3801 +13
+ Partials 548 547 -1
|
adityacs
force-pushed
the
2084_set_journaltarget_symbolic_priority
branch
from
e2f03a2
to
ea9e972
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Set JournalTarget Priority value to keyword
Which issue(s) this PR fixes:
Fixes #2084
Checklist