Allow configuring more options for output configuration #2089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `TenantID`, `BatchWait`, `BatchSize` and `AutoKubernetesLabels` options in the fluent-bit loki output plugin were not configurable. This change allows configuring those options via the helm chart.
|
|
jetersen
approved these changes
May 18, 2020
owen-d
reviewed
May 18, 2020
There was a problem hiding this comment.
This looks good, just a few comments.
- I'm a little worried that setting the default values in helm makes it harder to change them in the future because we'll have to make identical edits in two places. Can we instead inject those configs into the fluent-bit configmap only if defined? On the other hand, these options may be more discoverable with default entries in the helm config... 🤔
- I'm hesitant to encourage the
AutoKubernetesLabelsbecause iirc it ends up encouraging many small log streams in loki, which is not ideal. We've increasingly been discovering that being scarce with labels has been more performant. This is not a fault of this PR at all -- just something that made me stop and think. - Thanks for the review, I loved to see that!
Looking forward to getting this merged and excited to see some multi-tenant uses.
@cyriltovena @slim-bean WDYT?
Co-authored-by: Joseph Petersen <josephp90@gmail.com>
cyriltovena
reviewed
May 26, 2020
| loglevel: warn | ||
| lineFormat: json | ||
| k8sLoggingParser: "Off" | ||
| removeKeys: | ||
| - kubernetes | ||
| - stream | ||
| autoKubernetesLabels: false |
There was a problem hiding this comment.
The fact that this is default false is fine by me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The
TenantID,BatchWait,BatchSizeandAutoKubernetesLabelsoptions in the fluent-bit loki output plugin were not configurable. This change allows configuring those options via the helm chart.Which issue(s) this PR fixes:
None
Special notes for your reviewer:
All the values set in the values file should match the default values found here: https://github.com/grafana/loki/blob/master/cmd/fluent-bit/README.md#configuration-options
Checklist