Flush idle chunks properly #209
Conversation
gouthamve
force-pushed
the
flush-properly
branch
from
4fef908
to
e2b0692
Compare
|
Test is failing also. |
|
@tomwilkie Addressed feedback :) |
|
Another round please; making sure we get this right is important, but we're almost there. |
|
Hey guys, do I correctly understand the idea of that pull request is that it will reduce memory usage by cleaning up idle chunks of data? If you have no time to make changes to the PR, I can handle it (either providing patch right here in email-style or creating a new PR). I really love the idea of loki but it's unusable at the moment due to the problem with the memory leak. |
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
tomwilkie
force-pushed
the
flush-properly
branch
from
59cf992
to
5382776
Compare
|
Hi @kovetskiy! Sorry I didn't see your comment - I was on holiday last week, and only just getting caught up now. Its good that you asked first, and you can also try in slack, but in general you should always free free to pickup half finished PRs and finish them off. I'll try and be more responsive in the future. |
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
[release-5.6] LOG-4793: Upgrade dependencies
Signed-off-by: Goutham Veeramachaneni gouthamve@gmail.com