Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplifies/updates some of our configuration examples #2097

Merged
merged 1 commit into from
May 19, 2020

Conversation

owen-d
Copy link
Member

@owen-d owen-d commented May 19, 2020

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #2097 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2097      +/-   ##
==========================================
+ Coverage   61.24%   61.30%   +0.06%     
==========================================
  Files         146      146              
  Lines       11187    11187              
==========================================
+ Hits         6851     6858       +7     
+ Misses       3788     3784       -4     
+ Partials      548      545       -3     
Impacted Files Coverage Δ
pkg/promtail/targets/filetarget.go 70.48% <0.00%> (+1.80%) ⬆️
pkg/promtail/targets/tailer.go 78.40% <0.00%> (+4.54%) ⬆️

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owen-d owen-d merged commit 13424a2 into grafana:master May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants