Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix configuration docs #2139

Merged
merged 1 commit into from
May 27, 2020
Merged

Conversation

adityacs
Copy link
Collaborator

What this PR does / why we need it:
max_entries_limit_per_query was wrongly mentioned as max_entries_limit in configuration docs. This PR fixes it

Checklist

  • Documentation added

@adityacs
Copy link
Collaborator Author

@owen-d Sorry for the confusion caused in #1917. This was my mistake.

@codecov-commenter
Copy link

Codecov Report

Merging #2139 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2139      +/-   ##
==========================================
- Coverage   61.52%   61.46%   -0.06%     
==========================================
  Files         149      149              
  Lines       11935    11935              
==========================================
- Hits         7343     7336       -7     
- Misses       4010     4014       +4     
- Partials      582      585       +3     
Impacted Files Coverage Δ
pkg/promtail/targets/tailer.go 73.86% <0.00%> (-4.55%) ⬇️
pkg/promtail/targets/filetarget.go 68.67% <0.00%> (-1.81%) ⬇️

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit 5e0fe09 into grafana:master May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants