Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the ability to have a pull secrets for Promtail. #2141

Merged
merged 3 commits into from
Jun 2, 2020

Conversation

cyriltovena
Copy link
Contributor

Fixes #2118

Signed-off-by: Cyril Tovena cyril.tovena@gmail.com

Fixes grafana#2118

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #2141 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2141      +/-   ##
==========================================
- Coverage   61.23%   61.19%   -0.05%     
==========================================
  Files         146      146              
  Lines       11196    11196              
==========================================
- Hits         6856     6851       -5     
- Misses       3794     3797       +3     
- Partials      546      548       +2     
Impacted Files Coverage Δ
pkg/promtail/targets/tailer.go 73.86% <0.00%> (-4.55%) ⬇️
pkg/promtail/targets/filetarget.go 68.67% <0.00%> (-1.81%) ⬇️
pkg/logql/evaluator.go 91.27% <0.00%> (+0.58%) ⬆️

@owen-d owen-d merged commit 635dd0a into grafana:master Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[promtail] imagepullsecret for private repos
3 participants