Add flag to disable tracing activation #2191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #2191 +/- ##
==========================================
+ Coverage 61.60% 61.66% +0.05%
==========================================
Files 154 154
Lines 12310 12311 +1
==========================================
+ Hits 7583 7591 +8
+ Misses 4120 4108 -12
- Partials 607 612 +5
|
cyriltovena
reviewed
Jun 8, 2020
cmd/loki/loki-local-config.yaml
Outdated
| @@ -43,3 +43,6 @@ chunk_store_config: | |||
| table_manager: | |||
| retention_deletes_enabled: false | |||
| retention_period: 0s | |||
|
|
|||
| tracing: | |||
There was a problem hiding this comment.
I don't think we need to change the local config.
cyriltovena
approved these changes
Jun 8, 2020
|
btw you need to sign the CLA. |
|
Interesting that you say that, the cla bot seems to not work if I commit from my secondary e-mail which is my red hat e-mail. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR addresses the capability to disable tracing per configuration flag in enviroments where the Jaeger env variables are in place and thus auto-activate tracing. The config flag comes in hand as an user provided override to disable tracing if required.
Which issue(s) this PR fixes:
Fixes #2183
Checklist