Adds default -config.file for the promtail docker images. #2196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes grafana#2194. This is already the case for Loki. I think it's better to have this since most people would expect it as default at least for docker. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #2196 +/- ##
==========================================
+ Coverage 61.97% 61.99% +0.01%
==========================================
Files 154 154
Lines 12432 12432
==========================================
+ Hits 7705 7707 +2
+ Misses 4119 4118 -1
+ Partials 608 607 -1
|
owen-d
approved these changes
Jun 19, 2020
unguiculus
added a commit
to unguiculus/loki
that referenced
this pull request
Aug 31, 2020
This adjusts docker-compose.yaml to changes made in grafana#2196.
slim-bean
pushed a commit
that referenced
this pull request
Sep 1, 2020
This adjusts docker-compose.yaml to changes made in #2196.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2194.
This is already the case for Loki. I think it's better to have this since most people would expect it as default at least for docker. (which was the case for #2194 )
Signed-off-by: Cyril Tovena cyril.tovena@gmail.com