Render loki datasources even if Grafana is disabled. #2197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I didn't realize but this was a perfect ok use case to generate datasource when using a different grafana deployment. Fixes grafana#2186 Fixes grafana#2195 Now regarding grafana#2086 it seems pretty easy to use `.Values.grafana.sidecar.datasources.enabled` if you don't want any datasources. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #2197 +/- ##
==========================================
+ Coverage 61.97% 62.06% +0.08%
==========================================
Files 154 154
Lines 12432 12432
==========================================
+ Hits 7705 7716 +11
+ Misses 4119 4105 -14
- Partials 608 611 +3
|
srueg
approved these changes
Jun 8, 2020
owen-d
approved these changes
Jun 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't realize but this was a perfect ok use case to generate datasource when using a different grafana deployment.
Fixes #2186
Fixes #2195
Now regarding #2086 it seems pretty easy to use
.Values.grafana.sidecar.datasources.enabledif you don't want any datasources.Signed-off-by: Cyril Tovena cyril.tovena@gmail.com