Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve point allocations for each steps in the logql engine. #2216

Merged
merged 1 commit into from
Jun 19, 2020

Conversation

cyriltovena
Copy link
Contributor

Signed-off-by: Cyril Tovena cyril.tovena@gmail.com

❯ benchcmp old.txt new.txt
benchmark                         old ns/op      new ns/op      delta
BenchmarkRangeQuery100000-16      3177521        2690188        -15.34%
BenchmarkRangeQuery200000-16      13285761       11949290       -10.06%
BenchmarkRangeQuery500000-16      1925487305     1930636271     +0.27%
BenchmarkRangeQuery1000000-16     4044356716     3919126192     -3.10%

benchmark                         old allocs     new allocs     delta
BenchmarkRangeQuery100000-16      5239           5221           -0.34%
BenchmarkRangeQuery200000-16      5861           5793           -1.16%
BenchmarkRangeQuery500000-16      138631         138487         -0.10%
BenchmarkRangeQuery1000000-16     272012         271842         -0.06%

benchmark                         old bytes     new bytes     delta
BenchmarkRangeQuery100000-16      715357        696538        -2.63%
BenchmarkRangeQuery200000-16      1334607       1257068       -5.81%
BenchmarkRangeQuery500000-16      135321968     131401184     -2.90%
BenchmarkRangeQuery1000000-16     270956344     262054664     -3.29%

/cc @slim-bean

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #2216 into master will decrease coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2216      +/-   ##
==========================================
- Coverage   62.14%   62.12%   -0.02%     
==========================================
  Files         154      154              
  Lines       12457    12461       +4     
==========================================
  Hits         7741     7741              
- Misses       4108     4111       +3     
- Partials      608      609       +1     
Impacted Files Coverage Δ
pkg/logql/engine.go 88.96% <50.00%> (-1.04%) ⬇️
pkg/querier/queryrange/downstreamer.go 95.87% <0.00%> (-2.07%) ⬇️
pkg/logql/evaluator.go 92.30% <0.00%> (-0.42%) ⬇️
pkg/ingester/transfer.go 66.90% <0.00%> (+1.40%) ⬆️

@owen-d owen-d merged commit 314531c into grafana:master Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants