Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add readmes to individual helm charts #2233

Merged
merged 1 commit into from
Jun 22, 2020

Conversation

vyzigold
Copy link
Contributor

What this PR does / why we need it:
This PR adds readme file to each chart, so it can be shown on the helm hub. Currently the helm hub tries to find and show the file indefinitely, which doesn't look good: current loki chart page. With the readme files it will look similar to current fluentbit chart

Which issue(s) this PR fixes:
Fixes #1483

@CLAassistant
Copy link

CLAassistant commented Jun 17, 2020

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

Codecov Report

Merging #2233 into master will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2233      +/-   ##
==========================================
+ Coverage   62.04%   62.17%   +0.12%     
==========================================
  Files         156      156              
  Lines       12531    12531              
==========================================
+ Hits         7775     7791      +16     
+ Misses       4147     4130      -17     
- Partials      609      610       +1     
Impacted Files Coverage Δ
pkg/promtail/targets/filetarget.go 68.67% <0.00%> (-1.81%) ⬇️
pkg/logql/evaluator.go 92.72% <0.00%> (+0.41%) ⬆️
pkg/promtail/targets/tailer.go 78.40% <0.00%> (+2.27%) ⬆️
pkg/promtail/positions/positions.go 60.71% <0.00%> (+13.39%) ⬆️

Copy link
Member

@owen-d owen-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, thanks for this. The ingress/http basic auth bits are great.

@cyriltovena cyriltovena merged commit d307a0b into grafana:master Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm Hub cannot show README for loki, loki-stack, promtail
5 participants