Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logcli: Remove single newline from the raw line before printing. #2235

Merged
merged 1 commit into from
Jun 18, 2020
Merged

logcli: Remove single newline from the raw line before printing. #2235

merged 1 commit into from
Jun 18, 2020

Conversation

pstibrany
Copy link
Member

What this PR does / why we need it: This PR removes single newline at the end of raw log line. Lines are printed with Println, so this avoids having extra empty line between printed log lines.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

Lines are printed with Println, so this avoids having extra empty line
between printed log lines.

Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
@codecov-commenter
Copy link

Codecov Report

Merging #2235 into master will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2235      +/-   ##
==========================================
- Coverage   62.04%   62.02%   -0.03%     
==========================================
  Files         156      156              
  Lines       12531    12533       +2     
==========================================
- Hits         7775     7773       -2     
- Misses       4147     4151       +4     
  Partials      609      609              
Impacted Files Coverage Δ
pkg/logcli/output/raw.go 100.00% <100.00%> (ø)
pkg/logql/vector.go 68.75% <0.00%> (-18.75%) ⬇️
pkg/logql/evaluator.go 91.89% <0.00%> (-0.42%) ⬇️
pkg/querier/queryrange/downstreamer.go 97.93% <0.00%> (+2.06%) ⬆️
pkg/promtail/targets/tailer.go 78.40% <0.00%> (+2.27%) ⬆️

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit 9bf1130 into grafana:master Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants