Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: Add loadBalancerIP option to loki chart #2238

Merged
merged 3 commits into from
Jun 18, 2020

Conversation

vhrosales
Copy link
Contributor

@vhrosales vhrosales commented Jun 18, 2020

Add loadBalancerIP to loki
The chart's service already has annotation options enabled
https://github.com/grafana/loki/blob/master/production/helm/loki/templates/service.yaml#L15

One of the usages of the annotation is to add an internal load balancer and some cloud providers allow you to select a static IP like:

  service:
    annotations:
      service.beta.kubernetes.io/azure-load-balancer-internal: "true"
    type: LoadBalancer
    loadBalancerIP: 10.2.17.3

Test

$ helm3 upgrade --install loki ./loki-stack-0.38.0.tgz -f values/staging/loki.yaml --namespace infra  
Release "loki" has been upgraded. Happy Helming!
NAME: loki
LAST DEPLOYED: Thu Jun 18 16:43:03 2020
NAMESPACE: infra
STATUS: deployed
REVISION: 2
NOTES:
The Loki stack has been deployed to your cluster. Loki can now be added as a datasource in Grafana.

See http://docs.grafana.org/features/datasources/loki/ for more detail.
$ kubectl -n infra get svc
NAME                            TYPE           CLUSTER-IP     EXTERNAL-IP   PORT(S)          AGE
loki                            LoadBalancer   10.0.124.174   10.2.17.3     3100:30990/TCP   61m
loki-headless                   ClusterIP      None           <none>        3100/TCP         61m
prometheus-kube-state-metrics   ClusterIP      10.0.199.224   <none>        8080/TCP         6d5h
prometheus-node-exporter        ClusterIP      None           <none>        9100/TCP         6d5h
prometheus-server               LoadBalancer   10.0.137.207   10.2.17.2     80:31265/TCP     6d5h

@CLAassistant
Copy link

CLAassistant commented Jun 18, 2020

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

Codecov Report

Merging #2238 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2238      +/-   ##
==========================================
- Coverage   62.04%   62.00%   -0.04%     
==========================================
  Files         156      156              
  Lines       12531    12531              
==========================================
- Hits         7775     7770       -5     
- Misses       4147     4150       +3     
- Partials      609      611       +2     
Impacted Files Coverage Δ
pkg/promtail/targets/tailer.go 73.86% <0.00%> (-2.28%) ⬇️
pkg/promtail/targets/filetarget.go 68.67% <0.00%> (-1.81%) ⬇️

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit 4dd7a6c into grafana:master Jun 18, 2020
@vhrosales vhrosales deleted the add_loadbalancerip branch June 19, 2020 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants