Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add performance profile flags for logcli. #2248

Merged
merged 4 commits into from
Jun 25, 2020

Conversation

cyriltovena
Copy link
Contributor

Signed-off-by: Cyril Tovena cyril.tovena@gmail.com

Combined with --storage-config this allows you to profile a single query.

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
@pull-request-size pull-request-size bot added size/L and removed size/M labels Jun 22, 2020
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Jun 22, 2020

Codecov Report

Merging #2248 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2248   +/-   ##
=======================================
  Coverage   62.32%   62.32%           
=======================================
  Files         158      158           
  Lines       12760    12760           
=======================================
  Hits         7953     7953           
  Misses       4194     4194           
  Partials      613      613           
Impacted Files Coverage Δ
pkg/logql/evaluator.go 92.13% <0.00%> (-0.41%) ⬇️
pkg/promtail/targets/tailer.go 78.40% <0.00%> (+2.27%) ⬆️

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit 1e19aa4 into grafana:master Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants