Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loki: Remove redundant log warning #2250

Merged
merged 1 commit into from
Jun 23, 2020
Merged

Loki: Remove redundant log warning #2250

merged 1 commit into from
Jun 23, 2020

Conversation

slim-bean
Copy link
Collaborator

the grpc handler already logs this, we don't need to log it twice.

@codecov-commenter
Copy link

Codecov Report

Merging #2250 into master will decrease coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2250      +/-   ##
==========================================
- Coverage   62.44%   62.28%   -0.16%     
==========================================
  Files         158      158              
  Lines       12761    12760       -1     
==========================================
- Hits         7969     7948      -21     
- Misses       4177     4197      +20     
  Partials      615      615              
Impacted Files Coverage Δ
pkg/ingester/instance.go 60.63% <ø> (-0.18%) ⬇️
pkg/promtail/positions/positions.go 47.32% <0.00%> (-13.40%) ⬇️
pkg/promtail/targets/tailer.go 73.86% <0.00%> (-2.28%) ⬇️
pkg/promtail/targets/filetarget.go 68.67% <0.00%> (-1.81%) ⬇️

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit 60bf23d into master Jun 23, 2020
@cyriltovena cyriltovena deleted the remove-log-line branch June 23, 2020 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants