Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the lint issue merged to master. #2290

Merged
merged 1 commit into from
Jul 3, 2020
Merged

Conversation

cyriltovena
Copy link
Contributor

Signed-off-by: Cyril Tovena cyril.tovena@gmail.com

/cc @shuttie

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
@cyriltovena cyriltovena changed the title Fixes the lint issue merge to master. Fixes the lint issue merged to master. Jul 3, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #2290 into master will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2290      +/-   ##
==========================================
+ Coverage   62.35%   62.44%   +0.08%     
==========================================
  Files         158      158              
  Lines       12761    12761              
==========================================
+ Hits         7957     7968      +11     
+ Misses       4192     4178      -14     
- Partials      612      615       +3     
Impacted Files Coverage Δ
cmd/fluent-bit/loki.go 82.63% <ø> (ø)
pkg/querier/queryrange/downstreamer.go 95.87% <0.00%> (-2.07%) ⬇️
pkg/logql/evaluator.go 92.13% <0.00%> (-0.41%) ⬇️
pkg/promtail/positions/positions.go 60.71% <0.00%> (+13.39%) ⬆️

Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit 19be2c4 into grafana:master Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants