Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Fix CI helm test #2341

Merged
merged 1 commit into from
Jul 11, 2020
Merged

Build: Fix CI helm test #2341

merged 1 commit into from
Jul 11, 2020

Conversation

slim-bean
Copy link
Collaborator

looks like yamale 3.0.0 was released with a breaking change in a method parameter, pinning to 2.2.0

@codecov-commenter
Copy link

Codecov Report

Merging #2341 into master will increase coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2341      +/-   ##
==========================================
+ Coverage   61.24%   61.38%   +0.14%     
==========================================
  Files         158      158              
  Lines       12812    12812              
==========================================
+ Hits         7847     7865      +18     
+ Misses       4370     4351      -19     
- Partials      595      596       +1     
Impacted Files Coverage Δ
pkg/promtail/targets/file/filetarget.go 70.48% <0.00%> (+1.80%) ⬆️
pkg/promtail/positions/positions.go 60.71% <0.00%> (+13.39%) ⬆️

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@slim-bean slim-bean merged commit 7889e01 into master Jul 11, 2020
@slim-bean slim-bean deleted the test-helm-pin-yamale branch July 11, 2020 21:56
cyriltovena pushed a commit to cyriltovena/loki that referenced this pull request Jun 11, 2021
Also, I couldn't find a better way to do this.

Fixes: cortexproject/cortex#1425

Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants