Loki-Canary: Add query spot checking and metric count checking #2344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to make sure they are still in Loki. Add a context timeout to Loki queries
adding a metric test query
…y has been running to get accurate results until the requested range has been reached. Add a total spot check entry counter to get a ratio of success
cyriltovena
reviewed
Jul 13, 2020
cyriltovena
reviewed
Jul 13, 2020
cyriltovena
reviewed
Jul 13, 2020
Codecov Report
@@ Coverage Diff @@
## master #2344 +/- ##
==========================================
+ Coverage 61.50% 61.57% +0.06%
==========================================
Files 160 160
Lines 13422 13519 +97
==========================================
+ Hits 8255 8324 +69
- Misses 4546 4570 +24
- Partials 621 625 +4
|
cyriltovena
pushed a commit
to cyriltovena/loki
that referenced
this pull request
Jun 11, 2021
* Saner defaults for configs Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com> * Set spread_flushes to true in the code. Signed-off-by: Tom Wilkie <tom@grafana.com> * Make mockIngester implement HealthCheck and io.Closer so tests pass. Signed-off-by: Tom Wilkie <tom@grafana.com> * Address feedback Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com> * Verify that querier sees correct ring before using it. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Address feedback Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com> Co-authored-by: Tom Wilkie <tom@grafana.com> Co-authored-by: Peter Štibraný <peter.stibrany@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current canary implementation has been expanded to take a sample of entries created and query for them over time at a regular interval.
This should better exercise querying data as it moves from inmemory in ingesters to chunk storage to make sure data is consistently returned.
Additionally a metric query is run to count the logs over a period of time, this is helpful to exercise the Loki metrics query path as well as another sanity check that log data is being stored and retrieved properly.