Fixes LogQL grouping #2346
Merged
Fixes LogQL grouping #2346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #2346 +/- ##
==========================================
+ Coverage 61.50% 61.52% +0.01%
==========================================
Files 160 160
Lines 13422 13423 +1
==========================================
+ Hits 8255 8258 +3
+ Misses 4546 4544 -2
Partials 621 621
|
owen-d
approved these changes
Jul 13, 2020
|
nice catch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2334
A sort was missing on the group of labels (e.g
by(foo,bar,buzz)) causing data to be all over the place. I've added multiple tests reproducing the error and confirmed this is fixed.